]> git.baikalelectronics.ru Git - kernel.git/commit
mm: mremap: fix sign for EFAULT error return value
authorNiels Dossche <dossche.niels@gmail.com>
Tue, 10 May 2022 00:34:28 +0000 (17:34 -0700)
committerakpm <akpm@linux-foundation.org>
Tue, 10 May 2022 00:34:28 +0000 (17:34 -0700)
commit80b088d8a56aaf770eb84e75bdffbd21755f9955
tree5de7a0782ad18a7c3eb2486a9d47c7097f6446da
parente71719d976b4af96abad933cf306af6d0ba4ee4f
mm: mremap: fix sign for EFAULT error return value

The mremap syscall is supposed to return a pointer to the new virtual
memory area on success, and a negative value of the error code in case of
failure.  Currently, EFAULT is returned when the VMA is not found, instead
of -EFAULT.  The users of this syscall will therefore believe the syscall
succeeded in case the VMA didn't exist, as it returns a pointer to address
0xe (0xe being the value of EFAULT).  Fix the sign of the error value.

Link: https://lkml.kernel.org/r/20220427224439.23828-2-dossche.niels@gmail.com
Fixes: b5baa59aa48d ("mm, hugepages: add mremap() support for hugepage backed vma")
Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mremap.c