]> git.baikalelectronics.ru Git - kernel.git/commit
qlcnic: remove ndo_poll_controller
authorEric Dumazet <edumazet@google.com>
Thu, 27 Sep 2018 16:31:56 +0000 (09:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Sep 2018 18:12:29 +0000 (11:12 -0700)
commit808d91e86578abb46767f0c20f48887ed41f6142
tree745bdc2ec5c9551b5199c4334821fa939d5194f0
parente6c601bf4aa47942d80bbd6d92be9c7a669923d5
qlcnic: remove ndo_poll_controller

As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.

qlcnic uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Harish Patil <harish.patil@cavium.com>
Cc: Manish Chopra <manish.chopra@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c