]> git.baikalelectronics.ru Git - kernel.git/commit
drm/bridge: adv7511: Fix mutex deadlock when interrupts are disabled
authorArchit Taneja <architt@codeaurora.org>
Wed, 15 Jun 2016 10:50:45 +0000 (16:20 +0530)
committerArchit Taneja <architt@codeaurora.org>
Wed, 13 Jul 2016 08:54:36 +0000 (14:24 +0530)
commit806be673e635ad7d163fb096a7c376def10edfe3
tree2ab24e01aa051c3f481c043c8bca6de26507ae94
parentcbab8296b5c0f7f4b15ba5be6b91a1391e012344
drm/bridge: adv7511: Fix mutex deadlock when interrupts are disabled

When the adv7511 i2c client doesn't have an interrupt line, we observe a
deadlock on caused by trying to lock drm device's mode_config.mutex twice
in the same context.

Here is the sequence that causes it:

ioctl DRM_IOCTL_MODE_GETCONNECTOR from userspace
  drm_mode_getconnector (acquires mode_config mutex)
    connector->fill_modes()
    drm_helper_probe_single_connector_modes
      connector_funcs->get_modes
adv7511_encoder_get_modes
  adv7511_get_edid_block
    adv7511_irq_process
      drm_helper_hpd_irq_event (acquires mode_config mutex again)

In adv7511_irq_process, don't call drm_helper_hpd_irq_event when not
called from the interrupt handler. It doesn't serve any purpose there
anyway.

Signed-off-by: Archit Taneja <architt@codeaurora.org>
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c