]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: hotplug: Don't leak pci_slot on registration failure
authorLukas Wunner <lukas@wunner.de>
Thu, 19 Jul 2018 22:27:31 +0000 (17:27 -0500)
committerBjorn Helgaas <helgaas@kernel.org>
Mon, 23 Jul 2018 22:04:10 +0000 (17:04 -0500)
commit8018feeaef171572e1c7518aa36f4ebfe5e804b6
tree08cda7c0bcb14770f11dc13f017e1320ea0a59a2
parent33b3958c51d8a35bf9bbede9cca610502ea6c7e2
PCI: hotplug: Don't leak pci_slot on registration failure

If addition of sysfs files fails on registration of a hotplug slot, the
struct pci_slot as well as the entry in the slot_list is leaked.  The
issue has been present since the hotplug core was introduced in 2002:
https://git.kernel.org/tglx/history/c/a8a2069f432c

Perhaps the idea was that even though sysfs addition fails, the slot
should still be usable.  But that's not how drivers use the interface,
they abort probe if a non-zero value is returned.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org # v2.4.15+
Cc: Greg Kroah-Hartman <greg@kroah.com>
drivers/pci/hotplug/pci_hotplug_core.c