]> git.baikalelectronics.ru Git - kernel.git/commit
serial: samsung_tty: do not unlock port->lock for uart_write_wakeup()
authorJiri Slaby <jslaby@suse.cz>
Tue, 8 Mar 2022 11:51:53 +0000 (12:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Mar 2022 12:13:36 +0000 (13:13 +0100)
commit7fde2607048f1a982b55d89bc19bee4e04ccbab7
treee81ae27f0f13bf912d670c462dc3e09e989530f5
parent9d7eda98e52bee2210dfb21e47c1ea6b3284eb29
serial: samsung_tty: do not unlock port->lock for uart_write_wakeup()

The commit 1ae4f22f0254 (serial: samsung: fix potential soft lockup
during uart write) added an unlock of port->lock before
uart_write_wakeup() and a lock after it. It was always problematic to
write data from tty_ldisc_ops::write_wakeup and it was even documented
that way. We fixed the line disciplines to conform to this recently.
So if there is still a missed one, we should fix them instead of this
workaround.

On the top of that, s3c24xx_serial_tx_dma_complete() in this driver
still holds the port->lock while calling uart_write_wakeup().

So revert the wrap added by the commit above.

Cc: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Hyeonkook Kim <hk619.kim@samsung.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220308115153.4225-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung_tty.c