]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: ds1685: actually spin forever in poweroff path
authorJosh Poimboeuf <jpoimboe@redhat.com>
Fri, 15 Apr 2016 14:21:10 +0000 (09:21 -0500)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Fri, 20 May 2016 10:33:51 +0000 (12:33 +0200)
commit7f828a26fa4e8188e4b588c45821d9c9c90599f7
tree1ef6c0361cc58f39377a6c331743709ac7486447
parentf55235faa2213c912d49ad6553cac30131b81496
rtc: ds1685: actually spin forever in poweroff path

objtool reports the following warning:

  drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()

Similar to commit 344063eb0ed4 ("rtc: ds1685: actually spin forever in
poweroff error path"), there's another unreachable() annotation which is
actually reachable, which we missed the first time.

Actually spin forever to be consistent with the comment and to make the
unreachable() annotation guaranteed to be unreachable.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-ds1685.c