]> git.baikalelectronics.ru Git - kernel.git/commit
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 10 Apr 2018 13:17:29 +0000 (21:17 +0800)
committerJon Mason <jdmason@kudzu.us>
Mon, 11 Jun 2018 19:20:59 +0000 (15:20 -0400)
commit7f73a46529cc7d8938180fa9f1bd29bde48b3593
tree3aa9dfecafb053dfc07a1f2f8673c00fdd30c941
parentf7bbb0996cbfd372e08c9ccf4a5f930d18602958
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw

ntb_transport_setup_qp_mw() is never called in atomic context.

ntb_transport_setup_qp_mw() is only called by ntb_transport_link_work(),
which is set as a parameter of INIT_DELAYED_WORK()
in ntb_transport_probe().

Despite never getting called from atomic context,
ntb_transport_setup_qp_mw() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/ntb_transport.c