]> git.baikalelectronics.ru Git - kernel.git/commit
nfp: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 31 Jan 2019 00:38:59 +0000 (18:38 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Feb 2019 23:12:29 +0000 (15:12 -0800)
commit7f633ba8097b65281f939aafe421b6963d102e75
tree053144829866c45f775031e7c2722012130723a0
parent2b9bbb5da7ba2ca6328c6e5b600122d1893ab330
nfp: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c