]> git.baikalelectronics.ru Git - kernel.git/commit
sched/fair: Clean up comment in nohz_idle_balance()
authorAndrea Parri <andrea.parri@amarulasolutions.com>
Tue, 27 Nov 2018 11:01:10 +0000 (12:01 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 11 Dec 2018 13:54:57 +0000 (14:54 +0100)
commit7f3fa88503b701a6b3b3b122fa9ee3c5564769c1
tree54656be96ac5f6e3a06199911a0b0122129b4082
parent05d04fb8ca10b5d94a5dac6894e3b8b396f3fdf7
sched/fair: Clean up comment in nohz_idle_balance()

Concerning the comment associated to the atomic_fetch_andnot() in
nohz_idle_balance(), Vincent explains [1]:

  "[...] the comment is useless and can be removed [...]  it was
   referring to a line code above the comment that was present in
   a previous iteration of the patchset. This line disappeared in
   final version but the comment has stayed."

So remove the comment.

Vincent also points out that the full ordering associated to the
atomic_fetch_andnot() primitive could be relaxed, but this patch
insists on the current more conservative/fully ordered solution:

"Performance" isn't a concern, stay away from "correctness"/subtle
relaxed (re)ordering if possible..., just make sure not to confuse
the next reader with misleading/out-of-date comments.

[1] http://lkml.kernel.org/r/CAKfTPtBjA-oCBRkO6__npQwL3+HLjzk7riCcPU1R7YdO-EpuZg@mail.gmail.com

Suggested-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20181127110110.5533-1-andrea.parri@amarulasolutions.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c