]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: GPIO_GET_CHIPINFO_IOCTL: Fix information leak
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 18 Oct 2016 14:54:00 +0000 (16:54 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 21 Oct 2016 12:38:02 +0000 (14:38 +0200)
commit7ece85cb13ba51cd9f87384bda78bfd29497b61a
tree81da4136ccd901439b0f3ed777a7f2c1a520cd81
parente503c38b084829368bc793ee7e37cffa002f4280
gpio: GPIO_GET_CHIPINFO_IOCTL: Fix information leak

The GPIO_GET_CHIPINFO_IOCTL handler allocates a gpiochip_info struct on the
stack and then passes it to copy_to_user(). But depending on the length of
the GPIO chip name and label the struct is only partially initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Cc: stable@vger.kernel.org
Fixes: 89621c93093d ("gpio: add userspace ABI for GPIO line information")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c