]> git.baikalelectronics.ru Git - kernel.git/commit
libata: fix incorrect link online check during probe
authorTejun Heo <tj@kernel.org>
Tue, 6 Oct 2009 08:08:40 +0000 (17:08 +0900)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 7 Oct 2009 00:58:18 +0000 (20:58 -0400)
commit7e7696e8bcd9634363728ddaf88f60c79afc0302
treec1f501cb350776f60eb1d4deaf206b10ed852c4e
parent47dbd8a44152c1a52136be5868d8a2bec250a9af
libata: fix incorrect link online check during probe

While trying to work around spurious detection retries for
non-existent devices on slave links, commit
537a1d16e1c0421ed0d5c9a9df24885b9c06403c incorrectly added link
offline check logic before ata_eh_thaw() was called.  This means that
if an occupied link goes down briefly at the time that offline check
was performed, device class will be cleared to ATA_DEV_NONE and libata
wouldn't retry thus failing detection of the device.

The offline check should be done after the port is thawed together
with online check so that such link glitches can be detected by the
interrupt handler and handled properly.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Tim Blechmann <tim@klingt.org>
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-eh.c