]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: core: clear flags before allowing to retune
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 24 Jun 2021 15:16:14 +0000 (17:16 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 29 Jun 2021 14:28:50 +0000 (16:28 +0200)
commit7e72fc63c50ce9dd680e33178b335eca700d8e01
tree703223ca265bec84ccc1d3a01cff4c68b1c2b113
parent045f266e13ffafdbbd1b28a8ab43ac4274284c64
mmc: core: clear flags before allowing to retune

It might be that something goes wrong during tuning so the MMC core will
immediately trigger a retune. In our case it was:

 - we sent a tuning block
 - there was an error so we need to send an abort cmd to the eMMC
 - the abort cmd had a CRC error
 - retune was set by the MMC core

This lead to a vicious circle causing a performance regression of 75%.
So, clear retuning flags before we enable retuning to start with a known
cleared state.

Reported-by Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fixes: 3549448deda9 ("mmc: core: Flag re-tuning is needed on CRC errors")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210624151616.38770-2-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/core.c