]> git.baikalelectronics.ru Git - kernel.git/commit
perf: Fix task_function_call() error handling
authorKajol Jain <kjain@linux.ibm.com>
Thu, 27 Aug 2020 06:47:32 +0000 (12:17 +0530)
committerIngo Molnar <mingo@kernel.org>
Fri, 9 Oct 2020 06:18:33 +0000 (08:18 +0200)
commit7e29897e2e26e7448d0e45cb01efaa0627721a98
tree0b4ccabc93fef10e8c6f2929907527060549d49a
parent85038a5bbd6e9db598ab0a5355ddb82f99011549
perf: Fix task_function_call() error handling

The error handling introduced by commit:

  652f29113cde ("perf: Add cond_resched() to task_function_call()")

looses any return value from smp_call_function_single() that is not
{0, -EINVAL}. This is a problem because it will return -EXNIO when the
target CPU is offline. Worse, in that case it'll turn into an infinite
loop.

Fixes: 652f29113cde ("perf: Add cond_resched() to task_function_call()")
Reported-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Barret Rhoden <brho@google.com>
Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: https://lkml.kernel.org/r/20200827064732.20860-1-kjain@linux.ibm.com
kernel/events/core.c