]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: pvr2fb: initialize variables
authorTom Rix <trix@redhat.com>
Mon, 20 Jul 2020 19:18:45 +0000 (12:18 -0700)
committerSam Ravnborg <sam@ravnborg.org>
Wed, 5 Aug 2020 17:47:22 +0000 (19:47 +0200)
commit7da7dc47fd30c1927d644cfa5a4c30b146a206f7
treecb1cdc9b9312b6037477e462ce1d438889ac0648
parentb461adf71c0058bf534243a9f91c2ad4e67c1f57
video: fbdev: pvr2fb: initialize variables

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
  is an uninitialized value [core.CallAndMessage]
        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to
set the cable_arg[0].  If it does not, then some random
value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com
drivers/video/fbdev/pvr2fb.c