]> git.baikalelectronics.ru Git - kernel.git/commit
RDMA/cm: Fix memory leak in cm_add/remove_one
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Mon, 16 Sep 2019 07:11:51 +0000 (10:11 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 4 Oct 2019 17:58:31 +0000 (14:58 -0300)
commit7d5690e192ef371de7ae694a74aad25a11c42c11
treee85015a23fcae9d6e7a1ed8a14776e609004c405
parentd6394e228c15b419bd23c9dd4239c8f4a8638126
RDMA/cm: Fix memory leak in cm_add/remove_one

In the process of moving the debug counters sysfs entries, the commit
mentioned below eliminated the cm_infiniband sysfs directory.

This sysfs directory was tied to the cm_port object allocated in procedure
cm_add_one().

Before the commit below, this cm_port object was freed via a call to
kobject_put(port->kobj) in procedure cm_remove_port_fs().

Since port no longer uses its kobj, kobject_put(port->kobj) was eliminated.
This, however, meant that kfree was never called for the cm_port buffers.

Fix this by adding explicit kfree(port) calls to functions cm_add_one()
and cm_remove_one().

Note: the kfree call in the first chunk below (in the cm_add_one error
flow) fixes an old, undetected memory leak.

Fixes: 7df43cc391bc ("RDMA/cm: Move debug counters to be under relevant IB device")
Link: https://lore.kernel.org/r/20190916071154.20383-2-leon@kernel.org
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/cm.c