]> git.baikalelectronics.ru Git - kernel.git/commit
HID: amd_sfh: change global variables to static
authorTom Rix <trix@redhat.com>
Wed, 20 Apr 2022 14:22:44 +0000 (10:22 -0400)
committerJiri Kosina <jkosina@suse.cz>
Thu, 21 Apr 2022 08:18:54 +0000 (10:18 +0200)
commit7d061b826f1fba56ddb27d9f4ae81a4d7863217d
tree82c992b6f5296ce13dd57c4c0309608ecf6aea4f
parentd10b85f87f0130ab4c526f54de96eb3cf6220c9c
HID: amd_sfh: change global variables to static

Smatch reports this representative issue
amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
Similar issues for comp3_report_descriptor and als_report_descriptor.

Global variables should not be defined in header files.
This only works because amd_sfh_hid_report_desc.h in only included by
amd_sfh_hid_desc.c so change the storage-class specifiers to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h