]> git.baikalelectronics.ru Git - kernel.git/commit
cxgb4/cxgb4vf: Fixes regression in perf when tx vlan offload is disabled
authorHariprasad Shenai <hariprasad@chelsio.com>
Thu, 28 Jul 2016 07:58:57 +0000 (13:28 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sun, 31 Jul 2016 03:39:59 +0000 (20:39 -0700)
commit7cf6ccabc310a03a420655f11d574680ef123d62
tree44210434f0677d58165a5259929bb1d3a731db71
parentec3ff033ba6f716d5c921453ac4b9a80e54a77ed
cxgb4/cxgb4vf: Fixes regression in perf when tx vlan offload is disabled

The commit 4f7b5dbe539a ("cxgb4: Discard the packet if the length is
greater than mtu") introduced a regression in the VLAN interface
performance when Tx VLAN offload is disabled.

Check if skb is tagged, regardless of whether it is hardware accelerated
or not. Presently we were checking only for hardware acclereated one,
which caused performance to drop to ~0.17Mbps on a 10GbE adapter for
VLAN interface, when tx vlan offload is turned off using ethtool.
The ethernet head length calculation was going wrong in this case, and
driver ended up dropping packets.

Fixes: 4f7b5dbe539a ("cxgb4: Discard the packet if the length is greater than mtu")
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/sge.c
drivers/net/ethernet/chelsio/cxgb4vf/sge.c