]> git.baikalelectronics.ru Git - kernel.git/commit
acpi: utils: Cleanup acpi_dev_match_cb
authorSuzuki K Poulose <suzuki.poulose@arm.com>
Fri, 14 Jun 2019 17:53:58 +0000 (18:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Jun 2019 03:22:31 +0000 (05:22 +0200)
commit7c9e164026ef9efaae3ad23f4e30a3679c566119
tree69b5eb00890a11d69471a09d0c4dc862c53df2c1
parentf02aaaec2c0943430d756dd69aed5890e81d38b6
acpi: utils: Cleanup acpi_dev_match_cb

The prototype of bus_find_device() will be unified with that of
class_find_device() subsequently, but for this purpose the callback
functions passed to it need to take (const void *) as the second
argument.  Consequently, they cannot modify the memory pointed to by
that argument which currently is not the case for acpi_dev_match_cb().
However, acpi_dev_match_cb() really need not modify the "match" object
passed to it, because acpi_dev_get_first_match_dev() which uses it via
bus_find_device() can easily convert the result of bus_find_device()
into the pointer to return.

For this reason, update acpi_dev_match_cb() to avoid the redundant
memory updates.

Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/acpi/utils.c