]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: meson-gxl: fix interrupt handling in forced mode
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 3 Mar 2022 07:54:15 +0000 (08:54 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 5 Mar 2022 05:03:45 +0000 (21:03 -0800)
commit7c92640d8b793579b4fac822c1f5b57aab910a1a
tree8ad3b8847862969ec633bbeab98f0b5835eab8d0
parentf2bdfef3b20e6b1079383f58ac61cc881d18a7f2
net: phy: meson-gxl: fix interrupt handling in forced mode

This PHY doesn't support a link-up interrupt source. If aneg is enabled
we use the "aneg complete" interrupt for this purpose, but if aneg is
disabled link-up isn't signaled currently.
According to a vendor driver there's an additional "energy detect"
interrupt source that can be used to signal link-up if aneg is disabled.
We can safely ignore this interrupt source if aneg is enabled.

This patch was tested on a TX3 Mini TV box with S905W (even though
boot message says it's a S905D).

This issue has been existing longer, but due to changes in phylib and
the driver the patch applies only from the commit marked as fixed.

Fixes: 5238dfd30d59 ("net: phy: meson-gxl: remove the use of .ack_callback()")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/04cac530-ea1b-850e-6cfa-144a55c4d75d@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/meson-gxl.c