]> git.baikalelectronics.ru Git - kernel.git/commit
ocfs2: revert "ocfs2: fix NULL pointer dereference when dismount and ocfs2rec simulta...
authorXue jiufei <xuejiufei@huawei.com>
Mon, 23 Jun 2014 20:22:08 +0000 (13:22 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 23 Jun 2014 23:47:45 +0000 (16:47 -0700)
commit7c28c107f8b6322911ef8fe795815eb545d424a5
tree6fcea25a60fc4a9f1e622f528f64e00ae0e312d6
parentc5bc0e6fcf81f63a6f1e62a8f7bd9c8fde4fad53
ocfs2: revert "ocfs2: fix NULL pointer dereference when dismount and ocfs2rec simultaneously"

af85ecca4349 ("ocfs2: fix NULL pointer dereference when dismount and
ocfs2rec simultaneously") may cause umount hang while shutting down
truncate log.

The situation is as followes:
ocfs2_dismout_volume
-> ocfs2_recovery_exit
  -> free osb->recovery_map
-> ocfs2_truncate_shutdown
  -> lock global bitmap inode
    -> ocfs2_wait_for_recovery
          -> check whether osb->recovery_map->rm_used is zero

Because osb->recovery_map is already freed, rm_used can be any other
values, so it may yield umount hang.

Signed-off-by: joyce.xue <xuejiufei@huawei.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/super.c