]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: img-scb: fix reference leak when pm_runtime_get_sync fails
authorQinglang Miao <miaoqinglang@huawei.com>
Tue, 1 Dec 2020 09:31:39 +0000 (17:31 +0800)
committerWolfram Sang <wsa@kernel.org>
Wed, 14 Apr 2021 07:49:06 +0000 (09:49 +0200)
commit7bf93ede6ec2c5945184e9473f08eaa9f5a3d825
tree494d361be04bc24550b5aec97fa415a127f5b55f
parent5e30ccc16d275c89abe4199795b01e580ff699b3
i2c: img-scb: fix reference leak when pm_runtime_get_sync fails

The PM reference count is not expected to be incremented on
return in functions img_i2c_xfer and img_i2c_init.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: e89a0fcafcfe ("i2c: img-scb: Add runtime PM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-img-scb.c