]> git.baikalelectronics.ru Git - kernel.git/commit
osst: use noop_llseek() instead of default_llseek()
authorJan Blunck <jblunck@suse.de>
Wed, 26 May 2010 21:44:50 +0000 (14:44 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 27 May 2010 16:12:56 +0000 (09:12 -0700)
commit7be5f7f6dbaff2adfd52c0aaeab246ac8df7cb0e
tree963b06c2c139af0c8538dabc8238d613e73f8356
parent7e57eeb917632f86a5e709068514572894009d7d
osst: use noop_llseek() instead of default_llseek()

__os_scsi_tape_open() suggests that llseek() doesn't work: "We really want
to do nonseekable_open(inode, filp); here, but some versions of tar
incorrectly call lseek on tapes and bail out if that fails.  So we
disallow pread() and pwrite(), but permit lseeks."

Instead of using the fallback default_llseek() the driver should use
noop_llseek() which leaves the file->f_pos untouched but succeeds.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Willem Riede <osst@riede.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/osst.c