]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: m41t80: avoid i2c read in m41t80_sqw_is_prepared
authorTroy Kisky <troy.kisky@boundarydevices.com>
Fri, 3 Nov 2017 01:58:15 +0000 (18:58 -0700)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Wed, 8 Nov 2017 06:52:24 +0000 (07:52 +0100)
commit7bc73dc142d59fe31f7e39f9c0cc7267875bde3b
treeb8fad55d3f307c4d7e3802d66935bf5841c849e8
parent1a71ef10d718d969e288b6d403dfa8122c834b20
rtc: m41t80: avoid i2c read in m41t80_sqw_is_prepared

This is a little more efficient and avoids the warning

 WARNING: possible circular locking dependency detected
 4.14.0-rc7-00010 #16 Not tainted
 ------------------------------------------------------
 kworker/2:1/70 is trying to acquire lock:
  (prepare_lock){+.+.}, at: [<c049300c>] clk_prepare_lock+0x80/0xf4

 but task is already holding lock:
  (i2c_register_adapter){+.+.}, at: [<c0690b04>]
i2c_adapter_lock_bus+0x14/0x18

 which lock already depends on the new lock.

 the existing dependency chain (in reverse order) is:

 -> #1 (i2c_register_adapter){+.+.}:
        rt_mutex_lock+0x44/0x5c
        i2c_adapter_lock_bus+0x14/0x18
        i2c_transfer+0xa8/0xbc
        i2c_smbus_xfer+0x20c/0x5d8
        i2c_smbus_read_byte_data+0x38/0x48
        m41t80_sqw_is_prepared+0x18/0x28

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-m41t80.c