]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: amd: AMD RV RT5682 should depends on CROS_EC
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Tue, 3 Mar 2020 11:05:14 +0000 (12:05 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 3 Mar 2020 14:16:22 +0000 (14:16 +0000)
commit7ba6a38e8cff716e14a6ad285697f7c311b994bc
tree13978f1bd42daea525fc89caf7c5f1551ebab4bd
parent884b1c12074134bd754fbcd3ea04185afc423f6b
ASoC: amd: AMD RV RT5682 should depends on CROS_EC

If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:

 WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
 WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL

 ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
 i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
 ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
 cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
 ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
 cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'

This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
both depends on CROS_EC.

Fixes: 230502f241e1 ("ASoC: amd: Add machine driver for Raven based platform")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200303110514.3267126-1-enric.balletbo@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/Kconfig