]> git.baikalelectronics.ru Git - kernel.git/commit
pstore/ram: Do not treat empty buffers as valid
authorJoel Fernandes (Google) <joel@joelfernandes.org>
Sat, 3 Nov 2018 23:38:18 +0000 (16:38 -0700)
committerKees Cook <keescook@chromium.org>
Tue, 4 Dec 2018 00:52:35 +0000 (16:52 -0800)
commit7af87513312ec8d7cacd47f72b8fd89576d4f8a2
tree71c33eafa0fa9dd7a969b868fd9ae3cdda86e10a
parent6fea810ab2c0b95bf7b818b3d09e04d483a5f6e8
pstore/ram: Do not treat empty buffers as valid

The ramoops backend currently calls persistent_ram_save_old() even
if a buffer is empty. While this appears to work, it is does not seem
like the right thing to do and could lead to future bugs so lets avoid
that. It also prevents misleading prints in the logs which claim the
buffer is valid.

I got something like:

found existing buffer, size 0, start 0

When I was expecting:

no valid data in buffer (sig = ...)

This bails out early (and reports with pr_debug()), since it's an
acceptable state.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/pstore/ram_core.c