]> git.baikalelectronics.ru Git - kernel.git/commit
media: rkvdec: Fix H264 scaling list order
authorJonas Karlman <jonas@kwiboo.se>
Fri, 22 May 2020 20:21:33 +0000 (22:21 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Jun 2020 17:21:38 +0000 (19:21 +0200)
commit7aeae1b936a59b513371e6bcf848158680bd2517
tree184f43ff20942e4cbbda6f5ff2ef3dfb8fd91967
parente908f28eab802a7d882cb349c3dc520f4292f30b
media: rkvdec: Fix H264 scaling list order

The Rockchip Video Decoder driver is expecting that the values in a
scaling list are in zig-zag order and applies the inverse scanning process
to get the values in matrix order.

Commit 7033f8c5282f ("media: uapi: h264: clarify expected
scaling_list_4x4/8x8 order") clarified that the values in the scaling list
should already be in matrix order.

Fix this by removing the reordering and change to use two memcpy.

Fixes: 16832e0eb859 ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Tested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
[hverkuil-cisco@xs4all.nl: rkvdec_scaling_matrix -> rkvdec_h264_scaling_list]
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkvdec/rkvdec-h264.c