]> git.baikalelectronics.ru Git - kernel.git/commit
x86/mtrr: Don't copy uninitialized gentry fields back to userspace
authorColin Ian King <colin.king@canonical.com>
Tue, 18 Dec 2018 17:29:56 +0000 (17:29 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 18 Dec 2018 23:00:16 +0000 (00:00 +0100)
commit7ae5c5ac436601d2bfdc521ad8e095609d71fae3
tree094fdcdbc7efd6d5eca4287755face6de178256c
parenta530aa7591a2d32be41c6bf613258f2f2a6e0827
x86/mtrr: Don't copy uninitialized gentry fields back to userspace

Currently the copy_to_user of data in the gentry struct is copying
uninitiaized data in field _pad from the stack to userspace.

Fix this by explicitly memset'ing gentry to zero, this also will zero any
compiler added padding fields that may be in struct (currently there are
none).

Detected by CoverityScan, CID#200783 ("Uninitialized scalar variable")

Fixes: b7a081d69810 ("x86, mtrr: Use explicit sizing and padding for the 64-bit ioctls")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Tyler Hicks <tyhicks@canonical.com>
Cc: security@kernel.org
Link: https://lkml.kernel.org/r/20181218172956.1440-1-colin.king@canonical.com
arch/x86/kernel/cpu/mtrr/if.c