]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Initialize variable in qla8044_poll_reg()
authorTom Rix <trix@redhat.com>
Mon, 5 Oct 2020 14:45:44 +0000 (07:45 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Oct 2020 03:50:03 +0000 (23:50 -0400)
commit7a7d4a05536f555af7c7a3d73ad272ad39eb4ff7
treee408f0b84cc88fd6ae75c14d54a7b903cd13b358
parente77636c4d07689fa032621e8b6d12e8e0ab9dfc5
scsi: qla2xxx: Initialize variable in qla8044_poll_reg()

clang static analysis reports this problem:

qla_nx2.c:694:3: warning: 6th function call argument is
  an uninitialized value
        ql_log(ql_log_fatal, vha, 0xb090,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In qla8044_poll_reg(), when reading the reg fails, the error is reported by
reusing the timeout error reporter.  Because the value is unset, a garbage
value will be reported.  Initialize the value.

Link: https://lore.kernel.org/r/20201005144544.25335-1-trix@redhat.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nx2.c