]> git.baikalelectronics.ru Git - kernel.git/commit
blk-mq: include errors in did_work calculation
authorJens Axboe <axboe@fb.com>
Fri, 24 Mar 2017 18:04:19 +0000 (12:04 -0600)
committerJens Axboe <axboe@fb.com>
Fri, 24 Mar 2017 21:42:47 +0000 (15:42 -0600)
commit7a1954b67c02e43f0eb175742bee64ee6bdd2ff2
treeb83b77bd955222ba6783df11bd3807aac5e43c9a
parent1d503f7e5aa75a2a6172f67213e94a0c11914d81
blk-mq: include errors in did_work calculation

Currently we return true in blk_mq_dispatch_rq_list() if we queued IO
successfully, but we really want to return whether or not the we made
progress. Progress includes if we got an error return.  If we don't,
this can lead to a hang in blk_mq_sched_dispatch_requests() when a
driver is draining IO by returning BLK_MQ_QUEUE_ERROR instead of
manually ending the IO in error and return BLK_MQ_QUEUE_OK.

Tested-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-mq.c