]> git.baikalelectronics.ru Git - kernel.git/commit
ethernet: myri10ge: Fix a use after free in myri10ge_sw_tso
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Mon, 29 Mar 2021 12:36:48 +0000 (05:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Mar 2021 20:41:17 +0000 (13:41 -0700)
commit79f20430ae133b7ff3c21d6598ddabd076ec3249
treed2a57572fb66cf6e79aa83e02af97896bbea2182
parent8d2b83e0add28eaae17ce69c11221e0dcbd58880
ethernet: myri10ge: Fix a use after free in myri10ge_sw_tso

In myri10ge_sw_tso, the skb_list_walk_safe macro will set
(curr) = (segs) and (next) = (curr)->next. If status!=0 is true,
the memory pointed by curr and segs will be free by dev_kfree_skb_any(curr).
But later, the segs is used by segs = segs->next and causes a uaf.

As (next) = (curr)->next, my patch replaces seg->next to next.

Fixes: 5a236665acbed ("net: myri10ge: use skb_list_walk_safe helper for gso segments")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c