]> git.baikalelectronics.ru Git - kernel.git/commit
sc16is7xx: Defer probe if device read fails
authorAnnaliese McDermond <nh6z@nh6z.net>
Mon, 29 Mar 2021 20:10:49 +0000 (20:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Apr 2021 10:07:32 +0000 (12:07 +0200)
commit79d397caa222705699b1579589ac2340cb01bc47
tree2c01fd2d9284e27357faf08c8a522cddedfab51b
parentf466eed40c28ed05cecfbc16cb4edda4d61c41f5
sc16is7xx: Defer probe if device read fails

A test was added to the probe function to ensure the device was
actually connected and working before successfully completing a
probe.  If the device was actually there, but the I2C bus was not
ready yet for whatever reason, the probe fails permanently.

Change the probe so that we defer the probe on a regmap read
failure so that we try the probe again when the dependent drivers
are potentially loaded.  This should not affect the case where the
device truly isn't present because the probe will never successfully
complete.

Fixes: 31a09381692a ("sc16is7xx: Read the LSR register for basic device presence check")
Cc: stable@vger.kernel.org
Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>
Link: https://lore.kernel.org/r/010101787f9c3fd8-c1815c00-2d6b-4c85-a96a-a13e68597fda-000000@us-west-2.amazonses.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c