]> git.baikalelectronics.ru Git - kernel.git/commit
drm/omap: hdmi4_cec: Fix CEC clock handling for PM
authorTony Lindgren <tony@atomide.com>
Tue, 26 Mar 2019 15:14:37 +0000 (08:14 -0700)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 27 Mar 2019 09:10:51 +0000 (11:10 +0200)
commit7979bc3472b53fc32d0d96cde6dac495821a52a9
tree65bf00a85e1c174fc5ba9dede1f9e4028070a610
parent0fdbb5c2c472d1cb716933242ba91dd5e03fffad
drm/omap: hdmi4_cec: Fix CEC clock handling for PM

If CONFIG_OMAP4_DSS_HDMI_CEC is enabled in .config, deeper SoC idle
states are blocked because the CEC clock gets always enabled on init.

Let's fix the issue by moving the CEC clock handling to happen later in
hdmi_cec_adap_enable() as suggested by Hans Verkuil <hverkuil@xs4all.nl>.
This way the CEC clock gets only enabled when needed. This can be tested
by doing cec-ctl --playback to enable the CEC, and doing cec-ctl --clear
to disable it.

Let's also fix the typo for "divider" in the comments while at it.

Fixes: 769ebd7fb105 ("omapdrm: hdmi4_cec: add OMAP4 HDMI CEC support")
Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190326151438.32414-1-tony@atomide.com
drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c