]> git.baikalelectronics.ru Git - kernel.git/commit
caif_virtio: fix race between virtio_device_ready() and ndo_open()
authorJason Wang <jasowang@redhat.com>
Mon, 20 Jun 2022 05:11:14 +0000 (13:11 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 27 Jun 2022 12:04:30 +0000 (08:04 -0400)
commit7978320a5d5e7e58ac482ca51e583dfa45f15a7e
tree64dc6b1073a7603577a3a261eb521a835b33dac6
parent160090210939e304bc656a574f39ecfb623935eb
caif_virtio: fix race between virtio_device_ready() and ndo_open()

We currently depend on probe() calling virtio_device_ready() -
which happens after netdev
registration. Since ndo_open() can be called immediately
after register_netdev, this means there exists a race between
ndo_open() and virtio_device_ready(): the driver may start to use the
device (e.g. TX) before DRIVER_OK which violates the spec.

Fix this by switching to use register_netdevice() and protect the
virtio_device_ready() with rtnl_lock() to make sure ndo_open() can
only be called after virtio_device_ready().

Fixes: 708653892e139 ("caif_virtio: Introduce caif over virtio")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220620051115.3142-3-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/caif/caif_virtio.c