]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix cmd parser desc matching with masks
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Mon, 17 Aug 2020 19:59:26 +0000 (22:59 +0300)
committerJani Nikula <jani.nikula@intel.com>
Tue, 25 Aug 2020 08:01:34 +0000 (11:01 +0300)
commit7956a5c389ccde837a5a9526e90492a54bd738e6
treeef7251b270aef0d0647d25725199a9b40574d783
parent307d1b3e26310db573de01ed3dc4a02b4fb13ada
drm/i915: Fix cmd parser desc matching with masks

Our variety of defined gpu commands have the actual
command id field and possibly length and flags applied.

We did start to apply the mask during initialization of
the cmd descriptors but forgot to also apply it on comparisons.

Fix comparisons in order to properly deny access with
associated commands.

v2: fix lri with correct mask (Chris)

References: d065ef1f3949 ("drm/i915/cmdparser: Ignore Length operands during command matching")
Reported-by: Nicolai Stange <nstange@suse.de>
Cc: stable@vger.kernel.org # v5.4+
Cc: Miroslav Benes <mbenes@suse.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Tyler Hicks <tyhicks@canonical.com>
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200817195926.12671-1-mika.kuoppala@linux.intel.com
(cherry picked from commit 3b4efa148da36f158cce3f662e831af2834b8e0f)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/i915_cmd_parser.c