]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE."
authorNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:48:30 +0000 (12:48 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:48:30 +0000 (12:48 +1000)
commit78ccdf1ecdf0596a2b68a9b8dbbdce7283534c29
tree006200722d6313f3ed8680c2fee6bd8d66a9de91
parentcb89c01c70d5554c40246e32c4bdd6dca794e40a
Revert "md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE."

This reverts commit fa694d80913092a7e80ace8b4f3401bf32b04372.

While this patch seemed like a good idea and did help some workloads,
it hurts other workloads.
Large sequential O_DIRECT writes were faster,
Small random O_DIRECT writes were slower.

Other changes (batching RAID5 writes) have improved the sequential
writes using a different mechanism, so the net result of this patch
is definitely negative.  So revert it.

Reported-by: Shaohua Li <shli@kernel.org>
Tested-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c