]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: sfp: Fix unregistering of HWMON SFP device
authorAndrew Lunn <andrew@lunn.ch>
Mon, 24 Sep 2018 23:50:00 +0000 (01:50 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Sep 2018 03:23:31 +0000 (20:23 -0700)
commit78c8377c586ab0c88d64faa49523c71afe1befb8
tree6b1bf48c256946ca775c9ab0e7f6d0c77da5401d
parent20d68f45a467cef44d5fe1c91a0e52d5eaac0645
net: phy: sfp: Fix unregistering of HWMON SFP device

A HWMON device is only registered is the SFP module supports the
diagnostic page and is complient to SFF8472. Don't unconditionally
unregister the hwmon device when the SFP module is remove, otherwise
we access data structures which don't exist.

Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 3571a0f56659 ("net: phy: sfp: Add HWMON support for module sensors")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/sfp.c