]> git.baikalelectronics.ru Git - kernel.git/commit
ksmbd: fix guest connection failure with nautilus
authorNamjae Jeon <linkinjeon@kernel.org>
Mon, 17 Jan 2022 13:16:01 +0000 (22:16 +0900)
committerSteve French <stfrench@microsoft.com>
Tue, 18 Jan 2022 22:53:20 +0000 (16:53 -0600)
commit787ae19814b05db5dd82664be97708cb0c6939f4
treeafa4f13d4d452053ff80a469b9b35fc43501208b
parentee004ffffd4d3bdb73aad93dceb6ffa385df7526
ksmbd: fix guest connection failure with nautilus

MS-SMB2 describe session sign like the following.
Session.SigningRequired MUST be set to TRUE under the following conditions:
 - If the SMB2_NEGOTIATE_SIGNING_REQUIRED bit is set in the SecurityMode
   field of the client request.
 - If the SMB2_SESSION_FLAG_IS_GUEST bit is not set in the SessionFlags
   field and Session.IsAnonymous is FALSE and either Connection.ShouldSign
   or global RequireMessageSigning is TRUE.

When trying guest account connection using nautilus, The login failure
happened on session setup. ksmbd does not allow this connection
when the user is a guest and the connection sign is set. Just do not set
session sign instead of error response as described in the specification.
And this change improves the guest connection in Nautilus.

Fixes: 9445e1eebdb7 ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/smb2pdu.c