]> git.baikalelectronics.ru Git - kernel.git/commit
dma-buf: propagate errors from dma_buf_describe() on debugfs read
authorMathias Krause <minipli@googlemail.com>
Sun, 19 Jun 2016 12:31:29 +0000 (14:31 +0200)
committerSumit Semwal <sumit.semwal@linaro.org>
Mon, 20 Jun 2016 16:56:36 +0000 (22:26 +0530)
commit7878308c6e8467c58ec88867ab6e523f0c578655
tree826a3e829563dcae5e9a10420fee3718fb521231
parent5023bc7ceaaef18d785394e4b0a5570c7a00ee40
dma-buf: propagate errors from dma_buf_describe() on debugfs read

The callback function dma_buf_describe() returns an int not void so the
function pointer cast in dma_buf_show() is wrong. dma_buf_describe() can
also fail when acquiring the mutex gets interrupted so always returning
0 in dma_buf_show() is wrong, too.

Fix both issues by avoiding the indirection via dma_buf_show() and call
dma_buf_describe() directly. Rename it to dma_buf_debug_show() to get it
in line with the other functions.

This type mismatch was caught by the PaX RAP plugin.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Brad Spengler <spender@grsecurity.net>
Cc: PaX Team <pageexec@freemail.hu>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
drivers/dma-buf/dma-buf.c