]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Bluetooth: Update sec_level/auth_type for already existing connections"
authorJohan Hedberg <johan.hedberg@nokia.com>
Wed, 19 Jan 2011 06:36:48 +0000 (12:06 +0530)
committerGustavo F. Padovan <padovan@profusion.mobi>
Wed, 19 Jan 2011 16:40:42 +0000 (14:40 -0200)
commit780ee6b66ab4f2b652833670551ac706aea98fb9
treef544155e89e9c622fcc2a59c797e6da659370a13
parente7e7737dee816348f004c4018ed950c6b064690b
Revert "Bluetooth: Update sec_level/auth_type for already existing connections"

This reverts commit a4e421a3d227b38d2c50836d11a5524dd141696c. That
commit is wrong for two reasons:

- The conn->sec_level shouldn't be updated without performing
authentication first (as it's supposed to represent the level of
security that the existing connection has)

- A higher auth_type value doesn't mean "more secure" like the commit
seems to assume. E.g. dedicated bonding with MITM protection is 0x03
whereas general bonding without MITM protection is 0x04. hci_conn_auth
already takes care of updating conn->auth_type so hci_connect doesn't
need to do it.

Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
net/bluetooth/hci_conn.c