]> git.baikalelectronics.ru Git - kernel.git/commit
afs: Use the operation issue time instead of the reply time for callbacks
authorDavid Howells <dhowells@redhat.com>
Wed, 31 Aug 2022 12:16:42 +0000 (13:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 10:04:55 +0000 (12:04 +0200)
commit76faaa3be180df2bf6dca1e8d959fa80fa6dec67
tree7a937850849a68df7effcd721639298a6c4c1b39
parent57d504029721c1d1ce1613c1459ad5d174405c0a
afs: Use the operation issue time instead of the reply time for callbacks

[ Upstream commit 5be0a4f86974a569249cfa521b355dbc1f36c49b ]

rxrpc and kafs between them try to use the receive timestamp on the first
data packet (ie. the one with sequence number 1) as a base from which to
calculate the time at which callback promise and lock expiration occurs.

However, we don't know how long it took for the server to send us the reply
from it having completed the basic part of the operation - it might then,
for instance, have to send a bunch of a callback breaks, depending on the
particular operation.

Fix this by using the time at which the operation is issued on the client
as a base instead.  That should never be longer than the server's idea of
the expiry time.

Fixes: 9f6e95874a50 ("afs: Fix calculation of callback expiry time")
Fixes: 78290921b6ec ("rxrpc: Allow the reply time to be obtained on a client call")
Suggested-by: Jeffrey E Altman <jaltman@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/afs/flock.c
fs/afs/fsclient.c
fs/afs/internal.h
fs/afs/rxrpc.c
fs/afs/yfsclient.c