]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: mvebu: Fix i2c sda definition for 98DX3236
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Mon, 7 Sep 2020 21:17:10 +0000 (09:17 +1200)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 12 Sep 2020 16:14:39 +0000 (18:14 +0200)
commit76e04c70dfef3f4c605dc1e2b0e667f50d072735
treed087851da433da3505f0c2be65a176fae21fd739
parent307d1b3e26310db573de01ed3dc4a02b4fb13ada
pinctrl: mvebu: Fix i2c sda definition for 98DX3236

Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented
as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On
the board tested 0x4 resulted in a non-functioning i2c bus so stick with
0x1 which works.

Fixes: 0a736e93ff12 ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20200907211712.9697-2-chris.packham@alliedtelesis.co.nz
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mvebu/pinctrl-armada-xp.c