]> git.baikalelectronics.ru Git - kernel.git/commit
ata: libahci_platform: Sanity check the DT child nodes number
authorBaikal Electronics <support@baikalelectronics.ru>
Fri, 9 Sep 2022 19:36:06 +0000 (22:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:56 +0000 (13:22 +0200)
commit76d7de4eb9bb7fae75a22467bfb899162ceb44a3
tree80d966c21121f53d7cbd2bbdb9dae419eff37801
parentd27a136efe0e9d647257475affe212f4495ca42e
ata: libahci_platform: Sanity check the DT child nodes number

[ Upstream commit 01e9290e96ce05ed845dfc7bacceb4fd1b2d6b02 ]

Having greater than AHCI_MAX_PORTS (32) ports detected isn't that critical
from the further AHCI-platform initialization point of view since
exceeding the ports upper limit will cause allocating more resources than
will be used afterwards. But detecting too many child DT-nodes doesn't
seem right since it's very unlikely to have it on an ordinary platform. In
accordance with the AHCI specification there can't be more than 32 ports
implemented at least due to having the CAP.NP field of 5 bits wide and the
PI register of dword size. Thus if such situation is found the DTB must
have been corrupted and the data read from it shouldn't be reliable. Let's
consider that as an erroneous situation and halt further resources
allocation.

Note it's logically more correct to have the nports set only after the
initialization value is checked for being sane. So while at it let's make
sure nports is assigned with a correct value.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ata/libahci_platform.c