]> git.baikalelectronics.ru Git - kernel.git/commit
[media] tuner-core/simple: get_rf_strength can be tuner mode specific
authorHans Verkuil <hans.verkuil@cisco.com>
Sat, 6 Apr 2013 07:41:29 +0000 (04:41 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 14 Apr 2013 22:44:50 +0000 (19:44 -0300)
commit764a7903e6d0bc3aec8fd1a905c0d6e0c9442171
tree772748f182a85c71d118f94c8e38a2a8ef05f8f7
parentd0f75324b440a9c9ea875126254ea9312e6b6de0
[media] tuner-core/simple: get_rf_strength can be tuner mode specific

The get_rf_strength op in tuner-simple is valid only for the radio mode.
But due to the way get_signal in analog_demod_ops was designed it would
overwrite the signal value with a bogus value when in TV mode.
Pass a pointer to the signal value instead, and when not in radio mode
leave it alone in the tuner-simple.
This broke in commit db7c639b92504357c184bd5fd0f6a71d1e192b33
(tuner-core: call has_signal for both TV and radio) in kernel 3.6. Before
that this was working correctly. That commit did the right thing, but what
wasn't realized at the time was that tuner-simple should have been updated
as well to restrict setting the signal strength to the radio mode only.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-core/dvb_frontend.h
drivers/media/tuners/tda8290.c
drivers/media/tuners/tuner-simple.c
drivers/media/v4l2-core/tuner-core.c