]> git.baikalelectronics.ru Git - kernel.git/commit
usb: gadget: f_hid: fix refcount leak on error path
authorJohn Keeping <john@metanate.com>
Tue, 22 Nov 2022 12:35:22 +0000 (12:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:25 +0000 (11:41 +0100)
commit75fb42c2d0f25eb78285239a9765d2175f5f86b0
tree1fddecff022bdc449b56234d0783958bdb87be3f
parent17b928cdf5d3eced590df63fbaaa1d7cf8cef401
usb: gadget: f_hid: fix refcount leak on error path

[ Upstream commit 6904e5a2a67738a8ed3c5691233d389695a4cd51 ]

When failing to allocate report_desc, opts->refcnt has already been
incremented so it needs to be decremented to avoid leaving the options
structure permanently locked.

Fixes: 762995345ee2 ("usb: gadget: hid: add configfs support")
Tested-by: Lee Jones <lee@kernel.org>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Reviewed-by: Lee Jones <lee@kernel.org>
Signed-off-by: John Keeping <john@metanate.com>
Link: https://lore.kernel.org/r/20221122123523.3068034-3-john@metanate.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/f_hid.c