]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/huc: Adjust HuC state accordingly after GuC fetch error
authorMichał Winiarski <michal.winiarski@intel.com>
Wed, 8 Jul 2020 10:08:43 +0000 (12:08 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 8 Jul 2020 12:02:02 +0000 (13:02 +0100)
commit75aa2920183f11a68ce114cfa8d5423d81572453
tree1ce5fb65eff515802de958a8cbe17d07b4d7eb48
parent10179cc3614ffa0c783467ca8b676e727885b08f
drm/i915/huc: Adjust HuC state accordingly after GuC fetch error

Firmware "Selected" state is a transient state - we don't expect to see
it after finishing driver probe, we even have asserts sprinkled over
i915 to confirm whether that's the case.
Unfortunately - we don't handle the transition out of "Selected" in case
of GuC fetch error, leading those asserts to fire when calling
"intel_huc_is_used()".

v2: Add dbg print when moving HuC into error state (Daniele)

Reported-by: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200708100843.297655-2-michal@hardline.pl
drivers/gpu/drm/i915/gt/uc/intel_uc.c