]> git.baikalelectronics.ru Git - kernel.git/commit
drm: Remove drm_pending_event->pid
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 8 Mar 2017 14:12:43 +0000 (15:12 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 14 Mar 2017 13:38:33 +0000 (14:38 +0100)
commit7592d8a2799557bd9b8acdf72d5231a18acc5b2b
treec8f3bbbb86ca6223021e96a3ba55b9fcd5c26cda
parent815b6869e5ca056d2bd0d82b2dfa5d7121eb8de0
drm: Remove drm_pending_event->pid

We might as well dump the drm_file pointer, that's about as useful
a cookie as the pid. Noticed while typing docs for drm_file and friends.

Since the only consumer of this is the tracepoints I think we can safely
change this - those tracepoints should not be uapi relevant at all. It
all goes back to

commit ae475cdd92b444d93751ba85a0627b72e8aea33e
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Jul 1 16:48:09 2010 -0700

    drm: add per-event vblank event trace points

which doesn't give a special justification for using pid over a pointer.

Also note that the nouveau code setting it is entirely pointless:
Since this isn't a vblank event, it will never hit the vblank
tracepoints.

Cc: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170308141257.12119-11-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_irq.c
drivers/gpu/drm/drm_trace.h
drivers/gpu/drm/nouveau/nouveau_usif.c
include/drm/drm_file.h