]> git.baikalelectronics.ru Git - kernel.git/commit
net/sonic: Fix some resource leaks in error handling paths
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 3 Jan 2021 00:26:26 +0000 (11:26 +1100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Jan 2021 23:59:20 +0000 (15:59 -0800)
commit755866214524bccea42bf436d6034e422bdf18c2
tree687cf4b9cf7c513f912ba65f897e79bd1d6cbed5
parenta634d6a74dc21c287c2f441e2a57dab25faf952d
net/sonic: Fix some resource leaks in error handling paths

A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().

This is correctly freed in the remove function, but not in the error
handling path of the probe function. Fix this by adding the missing
dma_free_coherent() call.

While at it, rename a label in order to be slightly more informative.

Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Chris Zankel <chris@zankel.net>
References: commit 8f741229aa87 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
Fixes: 01b799412c82 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
Fixes: 2f74b9d37dfb ("[PATCH] macsonic/jazzsonic network drivers update")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/natsemi/macsonic.c
drivers/net/ethernet/natsemi/xtsonic.c