]> git.baikalelectronics.ru Git - kernel.git/commit
watchdog: da9062: do not ping the hw during stop()
authorMarco Felsch <m.felsch@pengutronix.de>
Mon, 20 Jan 2020 09:17:29 +0000 (10:17 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 17 Feb 2020 12:19:08 +0000 (13:19 +0100)
commit75272803c5dbe8314231cca509c07297830c78e1
tree586f820e308a810883c4d58b9a1c453bec0d50cc
parentfd439c6be8f3a1c608489d3ea27b5b679e5e4806
watchdog: da9062: do not ping the hw during stop()

The da9062 hw has a minimum ping cool down phase of at least 200ms. The
driver takes that into account by setting the min_hw_heartbeat_ms to
300ms and the core guarantees that the hw limit is observed for the
ping() calls. But the core can't guarantee the required minimum ping
cool down phase if a stop() command is send immediately after the ping()
command. So it is not allowed to ping the watchdog within the stop()
command as the driver does. Remove the ping can be done without doubts
because the watchdog gets disabled anyway and a (re)start resets the
watchdog counter too.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200120091729.16256-1-m.felsch@pengutronix.de
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/da9062_wdt.c