]> git.baikalelectronics.ru Git - kernel.git/commit
drm/atomic-helpers: Stall on the right commit
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 14 Jun 2016 17:50:58 +0000 (19:50 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 15 Jun 2016 15:14:24 +0000 (17:14 +0200)
commit74fae37cef1ec782f266f5816c0e4262b7e0be22
treea89748a0f1a1940701d22e439e7a444ff8f2c409
parent2e2ad499c6dcd65aa41c27264f7998b4bfb0b7b8
drm/atomic-helpers: Stall on the right commit

stall_checks carefully picked out the right commit to stall on, then
promptly used the wrong variable. Due to the break in the next loop
iteration this could be the 3rd commit, or if the list only has 2
entries commit would now point into the struct drm_crtc itself, at
some offset. Hilarity eventually ensues.

For added safety, also break right away instead of iterating once
more, but the real fix is waiting on stall_commit instead of commit.

Reported-and-tested-by: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1465926658-10110-1-git-send-email-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_atomic_helper.c