]> git.baikalelectronics.ru Git - kernel.git/commit
veth: Dont kfree_skb() after dev_forward_skb()
authorEric Dumazet <eric.dumazet@gmail.com>
Thu, 6 May 2010 07:53:53 +0000 (00:53 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 May 2010 07:53:53 +0000 (00:53 -0700)
commit74f21282e9f88490c5566ebae1a9d75f6522dc4c
tree5c023102ddce1ae5f5a7b05f1f42766537ef86d1
parent1cad72badd32fe72e73dce915f71ca8bab9a3e82
veth: Dont kfree_skb() after dev_forward_skb()

In case of congestion, netif_rx() frees the skb, so we must assume
dev_forward_skb() also consume skb.

Bug introduced by commit 17b75cd9f6cc8
(veth: move loopback logic to common location)

We must change dev_forward_skb() to always consume skb, and veth to not
double free it.

Bug report : http://marc.info/?l=linux-netdev&m=127310770900442&w=3

Reported-by: Martín Ferrari <martin.ferrari@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/veth.c
net/core/dev.c